Programmer Humor

19471 readers

1357 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago

MODERATORS

Review Please (programming.dev)

submitted 7 months ago by JPDev@programming.dev to c/programmer_humor@programming.dev

15 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] magic_lobster_party@kbin.run 0 points 7 months ago (1 children)

Had a coworker who was a bit like this. They were tasked to do one simple thing. Required a few lines of code change at most.

They end up refactoring the entire damn thing and introduced new bugs in the process.

[–] ripcord@lemmy.world 0 points 7 months ago (1 children)

Was there much value in the refactoring, like tech debt addressed?

[–] onlinepersona@programming.dev 1 points 7 months ago (1 children)

Doesn't matter. One concern per PR. Refactoring and tech debt are separate concerns.

[–] Jesus_666@feddit.de 0 points 7 months ago

Or, if the team does allow refactoring as part of an unrelated PR, have clean commits that allow me to review what you did in logical steps.

If that's not how you worked on the change than you either rewrite the history to make it look like you did or you'll have to start over.