this post was submitted on 29 Jul 2024
383 points (99.5% liked)

Programming

16971 readers
211 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev



founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
[–] aport@programming.dev 27 points 1 month ago (6 children)

GitLab still doesn't even support leaving comments on a commit message. Like, what? GitLab and GitHub have all these fancy shiny features but still suck at offering basic code review functionality.

I never understood the appeal.

[–] allywilson@lemmy.ml 29 points 1 month ago (2 children)

I mean, I get it, but that's also not a thing of git, right? Just because GitHub does something doesn't mean every other hosting provider needs to. If your code review process is to comment upon specific commits, maybe it's the code review process that's wrong?

[–] aport@programming.dev 4 points 1 month ago

GitHub doesn't let you comment on the commit message either. The only one I've seen do this properly this is Gerrit. And of course regular old mailing list reviews.

There are so many blogs and posts about writing good commit messages, using Conventional Commits, etc, and the two most popular forges don't even let you comment in-line on the commit message during a review.

[–] 0x0@lemmy.dbzer0.com 4 points 1 month ago

Git kinda has it? Have you seen git notes? https://git-scm.com/docs/git-notes

load more comments (3 replies)